Unsafe evolution: fix a race in version decoding - #85131
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The concurrency fix needs a regression test covering parallel first access.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes a race when caching decoded memory-safety rules for C# metadata modules.
Changes:
- Replaces nullable caching with thread-safe
SingleInitNullable. - Preserves decoding behavior using a non-capturing factory.
File summaries
| File | Description |
|---|---|
PEModuleSymbol.cs |
Makes version caching thread-safe. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
333fred
approved these changes
Sep 2, 2026
chsienki
added a commit
to chsienki/roslyn
that referenced
this pull request
Sep 2, 2026
Picks up dotnet#85131 (fix a race in version decoding), which resolves the CS9103 MemorySafetyRulesAttribute version-decoding errors that failed the VS insertion CloudBuild. Clean merge, no conflicts.
This was referenced Sep 3, 2026
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85130.
Test plan: #81207
Follow up on #84860.
Microsoft Reviewers: Open in CodeFlow